@W-21474595 - add MCP tool-level response token usage (responseCharCount)#400
Open
smuduganti-sf wants to merge 3 commits intosalesforcecli:mainfrom
Open
@W-21474595 - add MCP tool-level response token usage (responseCharCount)#400smuduganti-sf wants to merge 3 commits intosalesforcecli:mainfrom
smuduganti-sf wants to merge 3 commits intosalesforcecli:mainfrom
Conversation
smuduganti-sf
changed the title
smuduganti-sf
force-pushed
the
W-20995739-add-responseCharCount
branch
from
32cdc84 to
3b8b1ca
Compare
| if (result.isError) this.logger.debug(`Tool ${name} errored`); | ||
|
|
||
| // Calculate response character count for token usage | ||
| const responseCharCount = this.calculateResponseCharCount(result); |
Member
There was a problem hiding this comment.
This method only considers plain text from tool responses but tools can also have structured output, see:
https://modelcontextprotocol.io/specification/2025-11-25/server/tools#output-schema
I think the safe way would be to account for both since a tool seems to be able to return plain text + structured output
…ken usage (responseCharCount)
smuduganti-sf
force-pushed
the
W-20995739-add-responseCharCount
branch
from
5b62886 to
c75c061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@W-21474595@
What issues does this PR fix or reference?